[IMP] Add CI integration #2
Conversation
lasley
force-pushed
the
feature/ci-and-docs
branch
from
11ad5fc to
df36ba9
Compare
.travis.yml
Outdated
| - VERSION="1.0.0" | ||
| - RELEASE="1.0.0" | ||
| - AUTHOR_NAME="Sylvain Garancher" | ||
| - PYPI_USER="syleam" |
.travis.yml
Outdated
| - AUTHOR_NAME="Sylvain Garancher" | ||
| - PYPI_USER="syleam" | ||
| # Generate the below per repo with the following: | ||
| # travis encrypt 'PYPI_PASSWORD="$PYPI_PASSWORD"' -r LasLabs/repo-name |
There was a problem hiding this comment.
If you want PyPi, just do this and reply with the secure token so I can add.
travis encrypt 'PYPI_PASSWORD="PYPI PASSWORD"' -r syleam/python-zpl2
Note that if you're trying to maintain a defined release cycle or something, there's better tools (tox). This is just a pretty simple whatever is on master is a production type deal.
.travis.yml
Outdated
| # travis encrypt 'PYPI_PASSWORD="$PYPI_PASSWORD"' -r LasLabs/repo-name | ||
| # - secure: "$PYPI_TOKEN" | ||
| # Generate the below per repo with the following: | ||
| # travis encrypt 'GH_TOKEN="$GITHUB_TOKEN"' -r LasLabs/repo-name |
There was a problem hiding this comment.
If you want Github docs, just do this and reply with the secure token so I can add:
travis encrypt 'GH_TOKEN="GITHUB TOKEN"' -r syleam/python-zpl2
The Github token would be made in Github account settings, and will need write access to this repo.
You'll also need to make a gh-pages branch & clear it out like so - https://help.github.com/articles/creating-project-pages-using-the-command-line/
The bot will handle the rest, as you can see here. I recommend using a bot user instead of your own.
lasley
force-pushed
the
feature/ci-and-docs
branch
3 times, most recently
from
3ab4d34 to
85f801d
Compare
* Add travis * Add coveragerc * Update Readme to RST * Switch setup for automation * Add basic zpl2 init tests
lasley
force-pushed
the
feature/ci-and-docs
branch
from
85f801d to
d3e4d57
Compare
|
@sylvain-garancher any thoughts on this? |
|
Hello @lasley I developped the lib within the I din't have time to write docs, etc. (very busy at the moment), but this is required, obviously. For the |
Alright sweet I just left this part commented at the moment in the Travis file then. Once we get there, we can uncomment and create the gh-pages. I can alternatively remove if you'd prefer.
Removed PyPi section
Totally agree - I actually meant to curate this for the project and completely forgot. Done
I disagree in this case. The reasoning behind a gitignore is so that any contributor can hop in and start working in your repo with ease. What works in one minimal gitignore for you may not for someone else. We've found that this one is fairly inclusive to most development environments, without accidentally excluding the wrong things (except when Javascript starts coming into play). I'll obviously remove it if you prefer, but I just wanted to state my reasoning before that 😉 |
IMO, you shouldn't mix the project's configuration and the development environment's configuration. In short:
Some of my colleagues have a |
This PR adds CI:
Let me know if you don't want to use any of the above and I'll remove from the ReadMe. Once you enable Travis on your end, I will rebase so we know it works. Here's our build until then.
It also adds (disabled) docs generation to the gh-pages branch, and PyPy push if you want it. I'll comment inline for what we'll need to do to finish those though.
I also added two basic tests, mainly just so we know that CI is rigged up right. I didn't want to make the scope of this any larger than necessary.
Note that the
setup.pyis primarily automated now, which may not be desirable depending on how you do things. Let me know if that's the case & I'll switch back.Technical: